Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch merge checks action to pull_request_target event #338

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

PlasmaPower
Copy link
Collaborator

This is a copy of OffchainLabs/nitro#2477 for the geth repo. This should allow the check to run on 3rd party PRs from forks. CI will need bypassed to merge this, as the "design approved check" won't appear, because pull_request_target only runs when it's on the base branch.

@cla-bot cla-bot bot added the s CLA signed label Jul 11, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit e52de0a into master Jul 11, 2024
4 checks passed
@PlasmaPower PlasmaPower deleted the merge-checks-pr-target branch July 11, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants